Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add genotypes_matrix performance benchmark #2464

Merged
merged 3 commits into from Aug 16, 2022

Conversation

szhan
Copy link
Member

@szhan szhan commented Aug 16, 2022

Part of #678

@szhan szhan requested a review from benjeffery August 16, 2022 12:50
@szhan szhan self-assigned this Aug 16, 2022
@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #2464 (047e4d8) into main (da97323) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2464   +/-   ##
=======================================
  Coverage   93.43%   93.43%           
=======================================
  Files          28       28           
  Lines       27400    27400           
  Branches     1255     1255           
=======================================
  Hits        25600    25600           
  Misses       1766     1766           
  Partials       34       34           
Flag Coverage Δ
c-tests 92.24% <ø> (ø)
lwt-tests 89.05% <ø> (ø)
python-c-tests 71.17% <ø> (ø)
python-tests 98.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da97323...047e4d8. Read the comment docs.

@benjeffery
Copy link
Member

Thanks @szhan. I've modified the benchmark to use a sensible amount of RAM and added data for all previous releases.
Interestingly this confirms that the recent variant.decode work was a good decision!

@benjeffery benjeffery added the AUTOMERGE-REQUESTED Ask Mergify to merge this PR label Aug 16, 2022
@mergify mergify bot merged commit 1fe9ab7 into tskit-dev:main Aug 16, 2022
@mergify mergify bot removed the AUTOMERGE-REQUESTED Ask Mergify to merge this PR label Aug 16, 2022
@szhan szhan deleted the add_performance_benchmark branch August 16, 2022 18:35
@benjeffery benjeffery changed the title Add performance benchmark Add genotypes_matrix performance benchmark Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants