-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add message interface #31
Conversation
This is much better than my implementation. |
f7d8e19
to
e1023a3
Compare
There is another issue here, you render the titles passed by other scripts as titles in the menu, but this will cause the specified titles in the input.conf file to be overwritten. For example, input.conf:
This behavior is not what I want. Adding additional detection that only force overwrite when the corresponding title in the input.conf file is empty. |
As a convenience, if you don't want to override menu title and type, omit the corresponding field in json. |
326ef71
to
876d304
Compare
This is just what I wanted. |
66d6ea8
to
e910914
Compare
The last commit disrupted the JSON work of other scripts. |
Pushed a fix for it. I'm new to lua 🤣 . |
Not a completely correct fix, there is a syntax issue with determining that the table in the script is empty. |
Well, I just removed the check for empty table, after I realized that I have to iterate it to check if it is empty. In fact ,there maybe other cornercases here, I'm not going to validate all of them, because the C plugin will ignore them. |
|
Replaces #30.
example usage:
test.lua:
input.conf: