Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing flow control #273

Closed
jerch opened this issue Feb 12, 2020 · 1 comment
Closed

Missing flow control #273

jerch opened this issue Feb 12, 2020 · 1 comment
Labels

Comments

@jerch
Copy link
Contributor

jerch commented Feb 12, 2020

Running yes for several seconds runs into xterm.js's safety parachute:

image

This error indicates that over 50MB of write data is pending and still growing xterm.js' write buffer. I suggest to implement a flow control / backpressure mechanism, so noisy programs on the pty can be paused while xterm.js can catch up with the data (see https://xtermjs.org/docs/guides/flowcontrol/).

@jerch jerch added the bug label Feb 12, 2020
@tsl0922
Copy link
Owner

tsl0922 commented Dec 27, 2020

It's implemented on master now (4ab5479).

@tsl0922 tsl0922 closed this as completed Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants