Working build on windows #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated PR to reflect your latest changes. |
This was referenced Jan 13, 2023
|
quick type_of_file implementation works fine on mingw64+msys2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for this project, I managed to make it build on windows and by copying freetype.dll and SDL2.dll to the root project folder it also runs.
Main thing was missing freetype2 and the 1 code change you can see. The memset in the read_entire_file was because the second shader somehow had garbage at the end. the memset fixed it. But probably the bug is in passing the string to compile shader you might want to look into that.
I changed the build subsystem to console so you have the printf's available for testing. And I needed to disable some extra warnings (which I know you'd rather not do but I'm not sure how to fix them)
The introduced minirent.h include should have been with " not < and it uses assert.h (maybe minirent.h should include that but that is not your code right?)
Once again thanks for the repo and streaming, I really like them.
By the way, leave this PR open so I can keep it up to date if needed