Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the piecewise_interpolate_pulses function and its related functions (average_pitchtracks, interpolate_equal_pulses, etc.). See discussion in #10 for details, but the memory footprint and speed is drastically improved. In the process, a few major changes have been made:
section_by
if set to NULL.sort
now defaults to FALSE, since F0 datasets are typically already sorted.Under the hood behaviors that have changed:
.grouping
andaggregate_by
, we just return an ungrouped dataframe. This avoids having to keep regrouping things, which adds up quickly.this closes #10