Add SendBatch API #202
Add SendBatch API #202
Conversation
aaronbee
force-pushed
the
batch
branch
2 times, most recently
from
0a4d9e2
to
71f965d
Compare
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #202 +/- ##
==========================================
+ Coverage 69.54% 70.35% +0.80%
==========================================
Files 27 27
Lines 3596 3714 +118
==========================================
+ Hits 2501 2613 +112
- Misses 979 983 +4
- Partials 116 118 +2
☔ View full report in Codecov by Sentry. |
aaronbee
force-pushed
the
batch
branch
3 times, most recently
from
08d5895
to
00358c1
Compare
aaronbee
force-pushed
the
batch
branch
2 times, most recently
from
49d2be8
to
a9e6988
Compare
|
Latest version changes the API of SendBatch and gets rid of the Batch type: New API:
The |
|
Progress update: The new API feels better than my first attempt. This change is still missing tests. |
aaronbee
changed the title
aaronbee
force-pushed
the
batch
branch
2 times, most recently
from
32f41a9
to
6ffc0ac
Compare
|
Added unit tests for SendBatch. I think there are just a couple small changes I want to make. The change is ready for review. |
aaronbee
force-pushed
the
batch
branch
3 times, most recently
from
35f258d
to
90be048
Compare
Change the rpcs chan from holding hrpc.Call to []hrpc.Call. This is required for batch support.
Allows passing a batch of RPCs to the region client, which will be added to the in progress multi and then sent to HBASE. A note here is that it's possible for a multi to grow beyond the size of the configured size. This feels like the right way to go because the user of the Batch API has specifically requested the rpcs be batched together, so splitting the batch across multiple multi's breaks that bit of atomicity.
Removes a type assert in SendBatch.
| return res, allOK | ||
| } | ||
|
|
||
| rpcByClient, ok := c.findClients(ctx, batch, res) |
There was a problem hiding this comment.
Could be interesting to add an histogram to track how many regions are "targeted" by batch of RPC. To be added in following PR maybe.
Added the API:
The res has results in the same order as the RPCs in batch. Each RPCResult contains a result and an error. If the error is non-nil then the RPC failed or was not attempted. If it's nil the batch succeeded. The allOK is false if any of the results contain an error.
closes #68, closes #117