Added support for alternative zookeeper path roots. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 30.64% (diff: 40.00%)@@ master #21 diff @@
==========================================
Files 22 22
Lines 1755 1759 +4
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 538 539 +1
- Misses 1183 1186 +3
Partials 34 34
|
|
@timoha can you merge this PR? Required for people running more than one cluster with single zookeeper. |
timoha
reviewed
Feb 21, 2017
| @@ -33,16 +33,21 @@ func init() { | |||
| // in ZooKeeper | |||
| type ResourceName string | |||
|
|
|||
| // Prepend creates a new ResourceName with prefix prepended to the former ResourceName. | |||
| func (r ResourceName) Prepend(prefix string) ResourceName { | |||
| return ResourceName(prefix + string(r)) | |||
There was a problem hiding this comment.
should use filepath.Join in order to avoid double slashes if ZookeeperRoot has a trailing slash.
|
Unfortunately, I already deleted this fork. I will reproduce the changes now and open a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.