Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SAP Model Node ! #24

Closed
eertugrul opened this issue Dec 8, 2014 · 4 comments
Closed

Update SAP Model Node ! #24

eertugrul opened this issue Dec 8, 2014 · 4 comments
Assignees

Comments

@eertugrul
Copy link
Member

inputs:
StructuralModel
FilePath _ Optional GrabOpen SAp Intance is path is not provided

output
modified Structural Model 👍

workflow should be:
// 1. LoopOver Structural Model Elements
with element.GUID query the element in SAP
if exists update the properties of element (dynamo> sap)
if not exists create new element (frm) and return Label and set the item

//2, delete elements
Loop over SAP Model elements if not found in StructuralModel, delete them from the SAP Model.

@howesben @anagpuyol
I am thinking two options:
adding a Update.cs and and implementing all update nodes here! see below
or
we can add Bake.ToSap a boolean input for create/update? if false is creating if true updating the model. But we need also an optional Filepath if the SAPmodel is not opened already!

image

if update is true
update the open instance or exsitign one (use filepath)
if update false
create open new instance and save as given path if file path is set (path is optional)

Bake.ToSAP also needs Units input that I will implement it soon. Please let me know your thoughts.

@eertugrul eertugrul self-assigned this Dec 8, 2014
@eertugrul eertugrul added this to the Prototype - 0.0.1 milestone Dec 8, 2014
@anagpuyol
Copy link
Contributor

I like the Bake.ToSap with the bool update option! Basically, it is already doing the same thing: if the element doesn't exist, create it 🐙

@eertugrul
Copy link
Member Author

seamless integration ! this now working now without watch GUID's! I have added also Bool Delete property to allow partial sap model updates.

@bhowes-tt
Copy link
Member

for the record - somewhat related to #30, which is still open.

@eertugrul
Copy link
Member Author

I don't think we need any further changes on either Bake.toSAP and Collector to achieve #30 sap>dynamo>sap workflow. Because when we read from sap we pass original labels of sap elements to dynamo elements. We just need nodes where pass the and output modified object with same label.

for instance updateFrame node can be similar like fromLine node with additional input Frame!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants