Fixed bind to allow not specifying callback #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When binding an exchange to a queue which already has messages in it, one might want to be able to not subscribe to the queue with default options, e.g. to be able to use 'ack'. This fix enables you to only bind, so that you can subscribe later at any stage.
|
We can incorporate this, however it's a bit superfluous since you can declare the queue first bind it second – the specific Having said that. Update the Cheers! |
|
You're right about this being a bit superfluous, but it can make the user code slightly nicer. Thanks for the merge! |
algesten
added a commit
that referenced
this pull request
Feb 12, 2014
Fixed bind to allow not specifying callback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When binding an exchange to a queue which already has messages in it, one might want to be able to not subscribe to the queue with default options, e.g. to be able to use 'ack'.
This fix enables you to only bind, so that you can subscribe later at any stage.