Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented alias discover for require #112

Merged
merged 1 commit into from
Oct 6, 2018
Merged

Implemented alias discover for require #112

merged 1 commit into from
Oct 6, 2018

Conversation

AlexMost
Copy link
Member

@AlexMost AlexMost commented Oct 6, 2018

Issue - ttag-org/ttag#120

This syntax is ok for aliasing gettext to i18n:

const { gettext: i18n } = require('ttag')
i18n`test`;

@codecov
Copy link

codecov bot commented Oct 6, 2018

Codecov Report

Merging #112 into master will decrease coverage by 0.19%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #112     +/-   ##
=========================================
- Coverage   96.97%   96.78%   -0.2%     
=========================================
  Files          14       14             
  Lines        1225     1243     +18     
  Branches      191      195      +4     
=========================================
+ Hits         1188     1203     +15     
- Misses         37       40      +3
Impacted Files Coverage Δ
src/plugin.js 97.89% <100%> (-1.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f29f233...1ceae5f. Read the comment docs.

@AlexMost AlexMost merged commit bff51d0 into master Oct 6, 2018
@AlexMost AlexMost deleted the require-alias branch October 6, 2018 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant