New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix member expression extraction if this is present in member expression #82

Merged
merged 2 commits into from May 8, 2017

Conversation

Projects
None yet
2 participants
@AlexMost
Member

AlexMost commented May 8, 2017

The problem:

t`${ this.user.name } hello`

was extracted to "${ undefined.user.name } hello" instead of "${ this.user.name } hello"
@alxpy

@AlexMost AlexMost requested a review from alxpy May 8, 2017

@codecov

This comment has been minimized.

codecov bot commented May 8, 2017

Codecov Report

Merging #82 into master will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #82     +/-   ##
=========================================
+ Coverage   96.03%   96.14%   +0.1%     
=========================================
  Files          13       13             
  Lines        1059     1063      +4     
  Branches      151      152      +1     
=========================================
+ Hits         1017     1022      +5     
+ Misses         42       41      -1
Impacted Files Coverage Δ
src/utils.js 93.1% <100%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5190a63...dc0a6d3. Read the comment docs.

@AlexMost AlexMost merged commit 38015ee into master May 8, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@AlexMost AlexMost deleted the fix-member-extraction branch May 8, 2017

@alxpy

This comment has been minimized.

Member

alxpy commented May 9, 2017

nice 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment