Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support extracting text from vue files. #93

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Conversation

eavae
Copy link
Contributor

@eavae eavae commented Mar 23, 2020

Thanks for this really awesome tool. It's really what I need.

Recently, I worked on a VueJS project, there are a lot of .vue files. So, I made a little bit modifications to support that.

If there are any concerns or questions to merge this, please let me know.

@AlexMost
Copy link
Member

Hi @eavae!
Glad, that you have liked our library. Vue support is a really valuable feature. I have looked through your PR and it looks awesome. Thanks for your help!

Do you have some kind of example repo where you are using ttag and vue? It would be interesting for me to take a look, and to create some kind of quickstart for vue.

Anyway, thanks for your effort, will release a new cli vertion ASAP

@AlexMost AlexMost merged commit 545aeba into ttag-org:master Mar 23, 2020
@AlexMost
Copy link
Member

you can try ttag-cli@1.8.0. Please, let me know if that works for you!

@eavae
Copy link
Contributor Author

eavae commented Mar 24, 2020

Thanks a lot.

I will create a simple example to verify if it can works well with vue-loader and babel-plugin-ttag and the end to end process. If I made any progress, I will let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants