change current locale type #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job, would be great to update doc for the library also https://github.com/ttag-org/ttag/blob/master/docs/library-api.md |
stoyanovk
force-pushed
the
change_currentLocale_type
branch
from
1b0478a
to
9bce62a
Compare
stoyanovk
force-pushed
the
change_currentLocale_type
branch
from
9bce62a
to
7b33f7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I added available to add function as arg for useLocale method
It's need for resolving problem with global TTag instance when you use SSR and streaming
I made short demo when I use ttag with this changes and AsyncLocalStorage node js api
https://github.com/stoyanovk/asyncstorage_ttag_demo/blob/master/src/index.js