Skip to content
This repository has been archived by the owner on Nov 2, 2024. It is now read-only.

Add new LXC: Bookstack #2563

Closed
wants to merge 4 commits into from
Closed

Add new LXC: Bookstack #2563

wants to merge 4 commits into from

Conversation

MickLesk
Copy link
Contributor

@MickLesk MickLesk commented Feb 26, 2024

Description

And a new script. I go through the discussions from time to time and build new scripts. Even if I don't need them. The community will be happy :-)

In this case I have built Bookstack.
The LXC is quite resource-friendly, you are welcome to see if you want to reduce it a bit. In the same breath I have added the update script. This also works. I haven't noticed any bugs, but I'm not a hardcore user either.

Initial-Login (for your site):
User: admin@admin.com
Password: password

Request: #50

Type of change

Please delete options that are not relevant.

  • Bug fix
  • New feature
  • New Script
  • This change requires a documentation update

image

@MickLesk
Copy link
Contributor Author

@tteck @towerhand Ready for Testing :-)

@MickLesk
Copy link
Contributor Author

In addition:
Bookstack requires a fixed IP or a URL.
Initially I query the current IP of the system after the LXC creation.

=> If someone switches the IP or changes to a URL, this must be done in 2 places:

  • Apache2 - Config: /etc/apache2/sites-available/bookstack.conf (server name)
  • Bookstack - Config: /opt/bookstack/.env (APP_URL)

@tteck
Copy link
Owner

tteck commented Feb 26, 2024

There's a lot of work to do before this can be merged.

@MickLesk
Copy link
Contributor Author

Feel Free, I make the scripts to the best of knowledge and conscience. Unfortunately I have no way of contacting you :-)

In Germany we say: "nach besten Wissen und Gewissen" :-D

@tteck
Copy link
Owner

tteck commented Feb 26, 2024

I'm currently unable to dedicate the time or effort needed to refactor all of your PRs. This particular one stands out as it deviates significantly from the established patterns and conventions within our codebase.

@tteck tteck closed this Feb 26, 2024
@MickLesk
Copy link
Contributor Author

I'm currently unable to dedicate the time or effort needed to refactor all of your PRs. This particular one stands out as it deviates significantly from the established patterns and conventions within our codebase.

Okay, too bad, then. Your comment didn't come across as particularly nice either. So, I'll save myself the trouble in the future and keep my scripts to myself if they're that bad. Clear feedback would have been more helpful in understanding exactly what you don't like. This just brings frustration, and it makes me lose the desire to provide scripts

@tteck
Copy link
Owner

tteck commented Feb 26, 2024

I didn't mean to come across as offensive. If my words were interpreted that way, I apologize.

@tteck
Copy link
Owner

tteck commented Feb 26, 2024

Besides, you use the "TurnKey LXC Appliances" script to create a Bookstack LXC.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants