-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRAFT: split dlc schema into train, model, pose #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the split should be into two modules
- model and pose-estimation
- model training (which must import the other module)
I think model
and pose-estimation
should really go together, it wouldn't be much of a deeplabcut
element with just model
My motivation for splitting I expect...
In the ultimate version of this schema, will we still support the current 'run from on-disk files' process? Or will we want to push users away from that standard? If the former, it seems to me like 'only use the schema you need' is within the a-la-carte design philosophy of the elements. |
The way the |
oh - you're right. I previously though that we only relied on |
helper funcs: fixed bug where root_dir[0] would get appended to root_dirs whenever get_processed_dir was called. extract_new_bodyparts: added verbose arg to prevent duplicate print when calling model.Model.insert_new_model insert_new_model: because `BodyPart.extract_new_body_parts` returns a list, checking the truth value is ambiguous. Changed to 'is not None' infer_ouput_dir: remove _linking_module for VideoRecording table insert_new_params: Enforce int type on paramset_idx input. Previously failed to return when attempting to insert a duplicate bc str(x)!=int(x)
Co-authored-by: Thinh Nguyen <thinh@vathes.com>
Use `output_dir` as Path object in `save_yaml`
WIP. Does this split of schema roles work for you, @ttngu207? If so, I'll update documentation to reflect the split.
See corresponding workflow PR, specifically the pipeline which now includes VideoRecording.
forthcoming updates: