Fixed syntax error in #53 #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @joeyfigaro Thanks for contributing to the library. Could you please update the PR by removing the |
BeckyWu220
force-pushed
the
master
branch
4 times, most recently
from
42c67ac
to
8693ae4
Compare
|
Hi! @joeyfigaro Sorry for responding late to your PR. As you might had noticed, we had some new PRs merged. One of the PR had provided a typescript implementation, and this issue had been fixed in the same PR. You should not encounter this issue again in the next release (v1.3.x). Please feel free to test again in the new version that would be released soon. |
BeckyWu220
force-pushed
the
master
branch
4 times, most recently
from
89f120f
to
29494b9
Compare
|
@BeckyWu220 no worries! is this good to close, then? |
|
Hi @joeyfigaro Yes. I will go ahead and close the PR. Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#53