Add scenario outlines' examples insertions inside the DocString's content. #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttutisani
reviewed
Mar 8, 2024
source/Xunit.Gherkin.Quick/CoreModel/Scenario/GherkinScenarioOutlineExtensions.cs
Outdated
Show resolved
Hide resolved
source/Xunit.Gherkin.Quick.ProjectConsumer/Placeholders/Placeholders.cs
Outdated
Show resolved
Hide resolved
source/Xunit.Gherkin.Quick.ProjectConsumer/Placeholders/Placeholders.cs
Outdated
Show resolved
Hide resolved
farost
commented
Mar 8, 2024
source/Xunit.Gherkin.Quick.ProjectConsumer/Placeholders/Placeholders.cs
Outdated
Show resolved
Hide resolved
source/Xunit.Gherkin.Quick.ProjectConsumer/Placeholders/Placeholders.cs
Outdated
Show resolved
Hide resolved
|
@ttutisani The comments have been addressed! |
|
Can't merge, your tests fail due to line endings. I'm assuming you are on Linux/Unix, and I'm on windows.
You need to use Environment.NewLine in your tests instead of "Enter" to separate lines.
This is from Placeholders.cs. All errors come from there. You have a string in the assertions that has new-lines. This approach is generally a good practice to write cross-platform tests. |
|
Thanks! My bad, I'm too used to writing and running all the tests (even production ones) on Unix-based servers. I'll fix it tomorrow. |
|
Fixed + tested on Windows. Gonna run it on Mac tomorrow just in case. |
|
Tests pass on Mac as well! |
ttutisani
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes this issue by updating DocStrings' contents while running Scenario Outline tests based on the Examples table.
Following this similar issue's solution, both a unit test and a behaviour test are added.