New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: cleanup #15

Merged

ttytm merged 1 commit into main from refactor/dont-expose-internal-response-fields

Jul 21, 2023

Owner

ttytm commented Jul 21, 2023

Don't expose response fields only relevant for internal use.
Move head__ to _instruction_download.v as follow_download_head.
Abstract set download opts - light version of earlier error prone abstraction in e3899ad, without using a sumtype.
Set .writefunction in get / get_slice methods to remove an unnecessary conditional check in set_get_opts.


          refactor: don't expose response fields only relevant for internal use

b8ccf2a

ttytm merged commit 3071d96 into main

29 checks passed

ttytm deleted the refactor/dont-expose-internal-response-fields branch

July 21, 2023 08:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet