Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Profile page UI #152

Closed
5 of 7 tasks
minhhang107 opened this issue Feb 9, 2022 · 1 comment · Fixed by #199
Closed
5 of 7 tasks

Improve Profile page UI #152

minhhang107 opened this issue Feb 9, 2022 · 1 comment · Fixed by #199
Assignees
Labels
enhancement Issue that improves existing work frontend
Milestone

Comments

@minhhang107
Copy link
Collaborator

minhhang107 commented Feb 9, 2022

Is your feature request related to a problem? Please describe.
There're some enhancements we can do to improve Profile page

Are there any related issues? Please list all of them.

Describe the solution you'd like
None of the below affects the functionalities of the page but I think they're worth considering. Feel free to leave out any pieces that are not necessary

  • Add more padding to the bottom of the page
  • Make navbar fixed at top of screen and add more padding bottom for navbar
  • Remove the Save button when photo is on zoom (users probably don't want strangers to be able to save their photo)
  • Fix the size of user photo: we need to make all preview photos the same size. Currently horizontal and vertical photos look different
  • I think the horizontal space between photos is quite big? Maybe we can reduce the padding or put 4/5 photos on a row?
  • Maybe make the zoom screen smaller. I feel that when photo is zoomed, it takes the whole screen and is very overwhelming (especially with the black background). The photo zoom on Unsplash can be an inspiration, anyway this is just optional
  • Implement responsive design

Acceptance Criteria

  • New changes do not break current page
@minhhang107 minhhang107 added enhancement Issue that improves existing work frontend labels Feb 9, 2022
@oliver-pham
Copy link
Collaborator

Another important aspect is making sure it's mobile responsive as well. Current state:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue that improves existing work frontend
Projects
None yet
3 participants