-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/34b-enhance-user-profile-page #160
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tuanthanh2067/seeksi/GNLsg4UyNCEbpvBGGteNihfgYruB |
About the zoom feature of |
0774df8
to
ef94871
Compare
Here are some images of the profile page after the changes: However, I realized that the colour we used for the navbar was a bit transparent, which make the navbar look like this when on top of other elements: @minhhang107 and @hlavu you guys have any suggestions on which colour should we use as an alternative? |
I think we can do gradient from pink to white instead of to transparent |
ef94871
to
06bbbfe
Compare
06bbbfe
to
87d7f19
Compare
Hey I had a quick meeting with BE team earlier and they prefer grid of 3 so can you change it back to 3? You can refer to |
No worries! Thanks for letting me know. I'll make the changes as soon as possible. I'm sorry for the late reply |
* changed grid layout to 3 elements per row (on desktop) and 2 elements per row (on mobile) * added extra padding to the bottom of page * removed download option when viewing images from the gallery * made navbar fixed on top and added extra padding to the bottom * implemented responsive design draft
87d7f19
to
b8363fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Please pull the latest code then feel free to merge
Related issue
Fixes #152
Type of Change
Description
In response to @minhhang107 request on the PR for issue #34, I have made some small changes which should make the current UI looks a bit better, specifically:
As for figuring out how to reduce the image size when zoomed in, I have tried some options in lightGallery.js, but couldn't able to find any solutions.
Screenshot
Please add a screenshot of the changes made by this PR (if applicable)
Testing
Has this pull request been tested?
Please describe shortly how you tested it:
Note
The title of your PR should follow this format:
[Type](area): Title