Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/34b-enhance-user-profile-page #160

Closed
wants to merge 1 commit into from

Conversation

mqnguyen5
Copy link
Collaborator

@mqnguyen5 mqnguyen5 commented Feb 11, 2022

Related issue

Fixes #152

Type of Change

  • Feat: Change which adds functionality/new feature
  • Fix: Change which fixes an issue
  • Refactor: Change which improves the structure of the code
  • Docs: Change which improves documentation

Description

In response to @minhhang107 request on the PR for issue #34, I have made some small changes which should make the current UI looks a bit better, specifically:

  • Changed grid layout from 3 to 4 elements per row
  • Added extra padding to the bottom of page
  • Removed download option when viewing images from the gallery

As for figuring out how to reduce the image size when zoomed in, I have tried some options in lightGallery.js, but couldn't able to find any solutions.

Screenshot

Please add a screenshot of the changes made by this PR (if applicable)

Testing

Has this pull request been tested?

  • Yes

Please describe shortly how you tested it:

  • Chrome/Firefox Dev Tools

Note

The title of your PR should follow this format: [Type](area): Title

@vercel
Copy link

vercel bot commented Feb 11, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tuanthanh2067/seeksi/GNLsg4UyNCEbpvBGGteNihfgYruB
✅ Preview: https://seeksi-git-feature-34b-enhance-user-profile-page-tuanthanh2067.vercel.app

@minhhang107
Copy link
Collaborator

About the zoom feature of lightGallery, no worries we can skip it.
Can you refer to #152 and include other enhancements in this PR as well? Thanks~

@mqnguyen5
Copy link
Collaborator Author

mqnguyen5 commented Feb 14, 2022

Here are some images of the profile page after the changes:

Screen Shot 2022-02-13 at 11 18 02 PM

Screen Shot 2022-02-13 at 11 18 14 PM

Screen Shot 2022-02-13 at 11 18 26 PM

Screen Shot 2022-02-13 at 11 18 34 PM

Screen Shot 2022-02-13 at 11 19 02 PM

However, I realized that the colour we used for the navbar was a bit transparent, which make the navbar look like this when on top of other elements:

Screen Shot 2022-02-13 at 11 20 14 PM

@minhhang107 and @hlavu you guys have any suggestions on which colour should we use as an alternative?

@minhhang107 minhhang107 linked an issue Feb 14, 2022 that may be closed by this pull request
7 tasks
@minhhang107
Copy link
Collaborator

I think we can do gradient from pink to white instead of to transparent

@minhhang107
Copy link
Collaborator

Hey I had a quick meeting with BE team earlier and they prefer grid of 3 so can you change it back to 3? You can refer to Edit page to make the 2 pages consistent. I'm sorry for this inconvenience 😞

@mqnguyen5
Copy link
Collaborator Author

No worries! Thanks for letting me know. I'll make the changes as soon as possible. I'm sorry for the late reply

	* changed grid layout to 3 elements per row (on desktop) and 2 elements per row (on mobile)
	* added extra padding to the bottom of page
	* removed download option when viewing images from the gallery
	* made navbar fixed on top and added extra padding to the bottom
	* implemented responsive design

draft
Copy link
Collaborator

@minhhang107 minhhang107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Please pull the latest code then feel free to merge

@mqnguyen5 mqnguyen5 closed this Feb 17, 2022
@oliver-pham oliver-pham deleted the feature/34b-enhance-user-profile-page branch February 24, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Profile page UI
2 participants