Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Get opening lines #224

Merged
merged 7 commits into from
Feb 23, 2022
Merged

feature: Get opening lines #224

merged 7 commits into from
Feb 23, 2022

Conversation

dtnguyen22
Copy link
Collaborator

@dtnguyen22 dtnguyen22 commented Feb 22, 2022 •
edited
Loading

Related issue

Fixes #71

Type of Change

  • Feat: Change which adds functionality/new feature
  • Fix: Change which fixes an issue
  • Refactor: Change which improves the structure of the code
  • Docs: Change which improves documentation

Description

Authenticated users can get random opening lines, 9 at a time

Screenshot

GetOpeningLine() returns 9 lines

  • removed useCount
    image

Every time an opening line is used, its useCount increases by 1
Successful attempt
image

Failed attempt
image

Testing

Has this pull request been tested?

  • Yes please refer to the screenshots

Note

The title of your PR should follow this format: [Type](area): Title

@vercel
Copy link

vercel bot commented Feb 22, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tuanthanh2067/seeksi/6rbopL8JV68aEn8YCBsgrTu7MKhM
✅ Preview: https://seeksi-git-feature-71-get-opening-lines-tuanthanh2067.vercel.app

@oliver-pham oliver-pham changed the title Feature/71 get opening lines feature: Get opening lines Feb 22, 2022
tuanthanh2067
tuanthanh2067 requested changes Feb 22, 2022
View reviewed changes
backend/src/graphql/OpeningLine/datasource.js Outdated Show resolved Hide resolved
backend/src/graphql/OpeningLine/datasource.js Outdated Show resolved Hide resolved
@dtnguyen22 dtnguyen22 self-assigned this Feb 22, 2022
oliver-pham
oliver-pham requested changes Feb 22, 2022
View reviewed changes
Copy link
Collaborator

@oliver-pham oliver-pham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Can you add an extra line in each file if necessary and remove the redundant whitespace? I don't know why Prettier is not handling this for you.

backend/src/graphql/OpeningLine/types.js Outdated Show resolved Hide resolved
backend/src/graphql/OpeningLine/datasource.js Outdated Show resolved Hide resolved
oliver-pham
oliver-pham approved these changes Feb 23, 2022
View reviewed changes
Copy link
Collaborator

@oliver-pham oliver-pham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Appreciated 🙏

tuanthanh2067
tuanthanh2067 approved these changes Feb 23, 2022
View reviewed changes
Copy link
Owner

@tuanthanh2067 tuanthanh2067 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, approved!

@dtnguyen22 dtnguyen22 merged commit 04234eb into main Feb 23, 2022
@dtnguyen22 dtnguyen22 deleted the feature/71-get-opening-lines branch February 23, 2022 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver-pham oliver-pham oliver-pham approved these changes

@tuanthanh2067 tuanthanh2067 tuanthanh2067 approved these changes

Assignees

@dtnguyen22 dtnguyen22

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User conversation - get opening lines
3 participants
@dtnguyen22 @tuanthanh2067 @oliver-pham