Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more bins are placed and there are lanterns in the queue lines #76

Closed
RundesBalli opened this issue Jul 2, 2023 · 6 comments · Fixed by #82
Closed

No more bins are placed and there are lanterns in the queue lines #76

RundesBalli opened this issue Jul 2, 2023 · 6 comments · Fixed by #82
Labels
bug Something isn't working

Comments

@RundesBalli
Copy link

Probably something has been changed in the game, that the API for the addon has changed, or something?

In any case, it is no longer possible to place bins. Queue TV is only placed on every second path, and there are lanterns on the others. In the meantime, benches are also no longer placed.

Lanterns:
grafik

No more bins:
grafik

The error message is "cannot place that here, can not be placed in queue":
grafik

@KyuuGryphon
Copy link

Haven't been having this issue with lanterns, but I've definitely been having issues with bins. The plugin just doesn't place them at all, either automatically or using the Build on All Paths option. Version 0.5.1's Add button works, but 1.0.0 and 1.0.1 do not.

@Soma91
Copy link

Soma91 commented Oct 8, 2023

This PR changed the way the indices of footpathadditionplace work. If you replace addition + 1 with just addition in the Plugin js file it works as expected again.

@KyuuGryphon
Copy link

This PR changed the way the indices of footpathadditionplace work. If you replace addition + 1 with just addition in the Plugin js file it works as expected again.

Can confirm, that does the trick here! Much appreciated, thank you. :)

@JensMakerAdventures
Copy link

This PR changed the way the indices of footpathadditionplace work. If you replace addition + 1 with just addition in the Plugin js file it works as expected again.

Yes, this works. You need to do it in 2 places in the code and everything is OK again :)

@tubbo tubbo added the bug Something isn't working label Feb 19, 2024
tubbo added a commit that referenced this issue Feb 19, 2024
As a result of OpenRCT2/OpenRCT2#20177, we no longer need to mess with the
index number of the selected bin or bench. Adding the `+ 1` here was breaking
functionality on newer versions of OpenRCT2, and its removal has been confirmed
to work, so we're codifying it in the plugin now.

Shoutouts to @KyuuGryphon, @Soma91, and @JensMakerAdventures for finding the
fix for this one! Much obliged.

Fixes #76
tubbo added a commit that referenced this issue Feb 19, 2024
As a result of OpenRCT2/OpenRCT2#20177, we no longer need to mess with the
index number of the selected bin or bench. Adding the `+ 1` here was breaking
functionality on newer versions of OpenRCT2, and its removal has been confirmed
to work, so we're codifying it in the plugin now.

Shoutouts to @KyuuGryphon, @Soma91, and @JensMakerAdventures for finding the
fix for this one! Much obliged.

Fixes #76
@jayjayseal
Copy link

Can confirm this works. Thank you for finding this.

@RundesBalli
Copy link
Author

Can confirm this #76 (comment)

@tubbo tubbo closed this as completed in #82 May 3, 2024
@tubbo tubbo closed this as completed in 30434b5 May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants