-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flag to ignore error 204 #46
Comments
@clausnagel I have been giving some thought at this today. I don't think it's possible to do, and that we actually want that. Let me explain. Assume we have the polygon there: http://val3dity.readthedocs.io/en/v2/errors/#non-planar-polygon-normals-deviation If we ignore 204 then we might end up having val3dity crash because it's not possible to triangulate the top face: it gets projected to the xy-plane and thus you get duplicate points (triangulation is done by projecting to a plane). Also, if |
okay, I updated val3dity (branch v2) with the following behaviour. (it's now an option A ring is self-intersecting (error 104) if its projection to the best-fitted plane (done with least-square) through the vertices of the polygon containing the ring has a self-intersection. This rule is there because if it is not possible to project the rings/polygons to a plane, then it is not possible to triangulate it (which is necessary, at least by val3dity, to validate 3D primitives). If the rings of a polygon pass 203 (planarity with distance to fitted-plane) and have no self-intersection), then I can triangulate it (without modifying its geometry) and then 204 can be tested as before. The default value of 204 is now 20degree, but can be changed. option |
these are caused by vertices very close (like 0.001mm) to each others.
Temporary solution is to put planarity_n option to 180, but I'll add an option soon (in branch v2).
The text was updated successfully, but these errors were encountered: