Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added focus last window on window destroy and unmap #29

Merged
merged 5 commits into from
Mar 9, 2017

Conversation

allora
Copy link
Contributor

@allora allora commented Mar 6, 2017

Hey, noticed you guys talking about focusing the last window on unmap or destroy. So here you go :D

@tudurom
Copy link
Owner

tudurom commented Mar 6, 2017

Thank you for taking care of focused windows ;)

There is a tiny problem though, some parts of your code are indented with spaces. Windowchef's code is indented with tabs, aligned with spaces. (I really should write a contributor guide).

To fix it, assuming that you use vim, you can use this super retab function from vim wiki.

Thank you very much, as always.

@allora
Copy link
Contributor Author

allora commented Mar 7, 2017

Just a question or two. First, is there a particular size for the tab you are expecting (mine is set to 4)? Second, retabing the file affects more than my changes, if you're ok with those changes I can push the commit to my fork.

@tudurom
Copy link
Owner

tudurom commented Mar 7, 2017

  1. I have my tab size set to four, although there is no tab length expected. Because the code is indented with tabs and aligned with spaces, it will look good with any tab size.

  2. Yeah push it.

@tudurom
Copy link
Owner

tudurom commented Mar 8, 2017

Oh, christ. Cancel the retab commit and let me do the retab. It looks like all 4-space sequences were converted to tabs.

This reverts commit e1311b7.
@allora
Copy link
Contributor Author

allora commented Mar 9, 2017

Sorry about that, should be reverted.

@tudurom tudurom merged commit cd7ed84 into tudurom:master Mar 9, 2017
@tudurom
Copy link
Owner

tudurom commented Mar 9, 2017

(^_^)b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants