Implement flow map smoothing #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last subdivision node in an edge would have its child node set incorrectly.
I misunderstood the paper first and implemented it based on the straight-edge angles, but rather it's supposed to work based on the spiral angle parameters. This works quite well but some unstabilities occur.
I redid the derivative computations and changed the derivative functions in Spiral correspondingly. Also fix the smoothing cost gradient to also apply to the parent and child, which was missing before.
Also, document the formulas used for the smoothing cost.
The problem was that the α function was inverted (due to confusion over which of the two input points is the one further from the origin). Also renamed "force" to "gradient" to reduce sign confusion.
Willem3141
force-pushed
the
flowmap-optimization
branch
from
80e4f36
to
ce8bf02
Compare
Willem3141
commented
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the optimization procedure for flow maps. See #16. This implements all cost functions except for the obstacle cost. It also doesn't yet pick ε dynamically.
Also includes a corresponding demo application.