{To,From}{Bit,Byte}StreamWith: allow lifetime-constrained Contexts #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just realized this should also be applied to |
In current implementation, `From{Bit,Byte}StreamWith` impose that the `Context`
be static. In some cases, we want to pass a `Context` which owns a reference to
another struct.
This commit adds a lifetime to these traits to allow using a `Context`
constrained by a lifetime. Ex.:
```rust
impl FromBitStreamWith<'a> for FrameHeader {
type Context = StreamInfo<'a>;
[...]
}
```
Implementations for which the `Context` is `'static` bound can use:
```rust
impl FromBitStreamWith<'_> for FrameHeader {
type Context = StreamInfo;
[...]
}
```
In current implementation, `To{Bit,Byte}StreamWith` impose that the `Context`
be static. In some cases, we want to pass a `Context` which owns a reference to
another struct.
This commit adds a lifetime to these traits to allow using a `Context`
constrained by a lifetime. Ex.:
```rust
impl ToBitStreamWith<'a> for FrameHeader {
type Context = StreamInfo<'a>;
[...]
}
```
Implementations for which the `Context` is `'static` bound can use:
```rust
impl ToBitStreamWith<'_> for FrameHeader {
type Context = StreamInfo;
[...]
}
```
fengalin
force-pushed
the
from_reader-lt-constrained-context
branch
from
bfa3308
to
3ffca65
Compare
fengalin
changed the title
|
It's ready now. |
tuffy
approved these changes
Dec 1, 2023
tuffy
approved these changes
Dec 1, 2023
|
Thank you for your reactivity @tuffy! Since this requires a major version bump, I understand it might take some times before the next release. Do you have an idea when that could occur though? Just asking so I can schedule some downstream modifications accordingly. |
|
Thanks for the release @tuffy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning: this proposal introduces a breaking change. The change is as trivial as adding
<'_>, but all implementers of{To,From}{Bit,Byte}StreamWithwould be affected. IMO this would warrant a major version bump.See the examples for a complete use case.
In current implementation,
{To,From}{Bit,Byte}StreamWithimpose that theContextbe static. In some cases, we want to pass aContextwhich owns a reference to another struct.This MR adds a lifetime to these traits to allow using a
Contextconstrained by a lifetime. Ex.:Implementations for which the
Contextis'staticbound can use: