Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_network_object_by_device_and_object_id() returns wrong network object #8

Closed
packetinspector opened this issue Nov 20, 2017 · 1 comment

Comments

@packetinspector
Copy link

The Tufin API will return group members along with the group, so the logic in the function:

network_object = Network_Objects_List.from_xml_string(response_string)[0]

is not valid. The list needs to be searched for the requested ID and then returned instead. For example:

for n in Network_Objects_List.from_xml_string(response_string): if n.id == network_object_id: network_object = n break

geewrd referenced this issue in geewrd/pytos Mar 22, 2018
Fix get_network_object_by_device_and_object_id returning a wrong object
Close #8
geewrd referenced this issue in geewrd/pytos Mar 23, 2018
results are now filtered by id before being returned
fix #8
geewrd referenced this issue in geewrd/pytos Mar 23, 2018
results are now filtered by id before being returned
fix #8
geewrd referenced this issue in geewrd/pytos Mar 23, 2018
results are now filtered by id before being returned
fix #8
@tgratzi
Copy link
Collaborator

tgratzi commented Apr 28, 2018

Added

@tgratzi tgratzi closed this as completed Apr 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants