Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support changing the device name #82

Open
4 of 6 tasks
whot opened this issue Feb 12, 2018 · 2 comments
Open
4 of 6 tasks

Support changing the device name #82

whot opened this issue Feb 12, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@whot
Copy link
Contributor

whot commented Feb 12, 2018

The 0xbb command can set the device name, we should work that into the API. Few questions to be answered first though:

  • can the name be set during register only or anytime? - Name can be set any time
  • if during register only, how to work this into the API? Possibly by having Register() take the name argument. - can be done during normal connection
  • what came first, the poached egg or the fried chicken? - experts are divided on the question - but does the chicken comes from Kentucky?
  • set-name support on the Spark - see wacom: add support for a set_name on the Spark #83
  • set-name support on the Slate - see wacom: add support for a set_name on the Spark #83 -> same behavior than the Spark
  • set-name support on the Intuos Pro paper
@whot whot added the enhancement New feature or request label Feb 12, 2018
whot added a commit to whot/tuhi that referenced this issue Feb 13, 2018
bentiss pushed a commit that referenced this issue Feb 13, 2018
@bentiss
Copy link
Collaborator

bentiss commented Feb 14, 2018

Regarding the API, I think we should let the client handle most of the subtleties.
We should have a SetName(name) DBus call, and document that the name will be changed the next time the device connects, and then the bluez stack might see the change only at the next advertising report.

So basically, put some big warning: you can change the name, but you'll have to keep your internal state yourself.

@bentiss
Copy link
Collaborator

bentiss commented Feb 14, 2018

One other solution, as the Android app has no issue setting the name during register. Register() takes the name as an argument, and once we are doing the second part of registering (where we check on the firmware and name, we set the name here). The bluez stack might notbe updated still, so we still need to tell the client to check on the internal state

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants