Fix target attribute optionality

[yonaskolb]

#517 made a breaking change to make targetAttributes optional.

This PR fixes:

• project equality always returning false if targetAttributes were optional
• makes targetAttributes non optional, as they are always set in both the initializers. The attributes are always still written which solves the aim of Make target attributes optional #517

[github-actions]

@yonaskolb your pull request is missing a changelog!

[yonaskolb]

Fixes incorrect case were both were nil

[pepicrft]

project equality always returning false if targetAttributes were optional

Awesome! Thanks for tackling this.

makes targetAttributes non optional, as they are always set in both the initializers. The attributes are always still written which solves the aim of #517

The rule we have been following to decide whether an attribute should be or not optional is that the attribute should be optional if Xcode is able to open a project with the attribute not define. That's the case for targetAttributes and therefore should remain as optional. It's an unfortunate breaking change.

[yonaskolb]

The rule we have been following to decide whether an attribute should be or not optional is that the attribute should be optional if Xcode is able to open a project with the attribute not define. That's the case for targetAttributes and therefore should remain as optional. It's an unfortunate breaking change.

As per #517 though, this property is always written so that Fastlane can open it. There's no room for it to be optional

[pepicrft]

As per #517 though, this property is always written so that Fastlane can open it. There's no room for it to be optional

Although I disagree with going down that path, it's not a big deal so let's merge this and revisit it before the next major version to avoid breaking changes.

[pepicrft]

I'll release a new version right after the merge

[yonaskolb]

Thank you @pepibumur! :)