Tuist executable #3494

fortmarek · 2021-09-22T18:29:18Z

Short description 📝

In this PR I added a functionality where if you run tuist xxx and xxx is not tuist's command, tuist will automatically try to run an executable from PATH.

Checklist ✅

The code architecture and patterns are consistent with the rest of the codebase.
The changes have been tested following the documented guidelines.
In case the PR introduces changes that affect users, the documentation has been updated.

danieleformichelli · 2021-09-22T18:37:24Z

Sources/TuistKit/Commands/TuistCommand.swift

+            } else {
+                executeCommand = {
+                    var customCommandArguments = processedArguments
+                    customCommandArguments[0] = "tuist-\(customCommandArguments[0])"
+                    try System.shared.runAndPrint(customCommandArguments)
+                }


Should we check somehow if the command exists?
Otherwise if I do a typo (e.g. tuist generata), it might be hard to understand what's happening

that is a very good point, yeah, we can check with which xxx, I'll do that.

Yeah, that's a good idea. What about extracting that logic into its own component that we can test in isolation. Otherwise this TuistCommand will grow significantly in responsibilities.

projects/docs/docs/commands/task.md

pepicrft

Besides what @danyf90 mentioned. The changes look good!

Co-authored-by: Daniele Formichelli <df@bendingspoons.com>

Sources/TuistKit/Commands/TuistCommand.swift

Co-authored-by: Daniele Formichelli <df@bendingspoons.com>

* Search for executable in path with tuist prefix if not tuist command * Add acceptance test for new task * Update documentation * Check if executable exists * Update projects/docs/docs/commands/task.md Co-authored-by: Daniele Formichelli <df@bendingspoons.com> * Update Sources/TuistKit/Commands/TuistCommand.swift Co-authored-by: Daniele Formichelli <df@bendingspoons.com> * Fix finding command Co-authored-by: Daniele Formichelli <df@bendingspoons.com>

* Tuist executable (#3494) * Search for executable in path with tuist prefix if not tuist command * Add acceptance test for new task * Update documentation * Check if executable exists * Update projects/docs/docs/commands/task.md Co-authored-by: Daniele Formichelli <df@bendingspoons.com> * Update Sources/TuistKit/Commands/TuistCommand.swift Co-authored-by: Daniele Formichelli <df@bendingspoons.com> * Fix finding command Co-authored-by: Daniele Formichelli <df@bendingspoons.com> * WIP: Fetch release * Install tasks to release dir * Execute plugin task * Add TuistServiceTests * Add FetchServiceTests * Remove DependenciesFetchCommand * Add fetch plugins test * Fix PluginServiceTests * Add test for new logic in PluginServiceTests * Minor changes * Revert changes to Package.resolved * Add missing throws * Rename gitID to gitReference * Move to Swift-based APIs * Fix fetch command * Uncomment analytics code * Fix acceptance tests for tuist edit * Restore Package.resolved * Fix plugins.feature acceptance test * Add fetch to tasks.feature * Add fetch to tasks.feature * Add fetch to scaffold.feature * Fix scaffold.feature * Fix tasks.feature Co-authored-by: Daniele Formichelli <df@bendingspoons.com>