3️⃣ Merge `tuist focus` and `tuist generate` command #3912

danieleformichelli · 2021-12-28T20:09:16Z

No description provided.

…mentation with focus

luispadron

This is a great direction!

Sources/TuistKit/Commands/GenerateCommand.swift

adellibovi · 2022-01-02T10:43:26Z

As commented on Slack, maybe we can soft-deprecate the command and redirect tuist focus to tuist generate? In that case we don't really need to wait for a 3.0. What do you think?

projects/docs/docs/commands/generate.md

Co-authored-by: ezraberch <49635435+ezraberch@users.noreply.github.com>

# Conflicts: # CHANGELOG.md # Sources/TuistKit/Commands/TuistCommand.swift # projects/fourier/lib/fourier.rb # projects/fourier/lib/fourier/services/focus.rb # projects/fourier/test/fourier/services/focus_test.rb # projects/fourier/test/fourier/services/generate/tuist_test.rb # projects/tuist/features/step_definitions/shared/tuist.rb

Sources/TuistKit/Commands/GenerateCommand.swift

projects/docs/docs/commands/generate.md

fortmarek · 2022-01-08T18:44:50Z

As commented on Slack, maybe we can soft-deprecate the command and redirect tuist focus to tuist generate? In that case we don't really need to wait for a 3.0. What do you think?

I'd rather make the change in one go as it might be wasted effort to support both tuist generate XYZ and tuist focus XYZ.

Co-authored-by: Marek Fořt <marekfort@me.com>

# Conflicts: # projects/docs/docs/building-at-scale/caching.md # projects/docs/docs/commands/focus.md

fortmarek

I'm good with this approach, thanks for working on this @danyf90 👏

* 3️⃣ Remove deprecated deprecated initializers for `FileLists`, `Headers`, and `HTTPURLResponse` (#3936) * chore: remove deprecated initializers for `FileLists`, `Headers`, and `HTTPURLResponse` * fix: fix fixtures * Plugins 2.0 (#3492) * Edit CHANGELOG * Tuist executable (#3494) * Search for executable in path with tuist prefix if not tuist command * Add acceptance test for new task * Update documentation * Check if executable exists * Update projects/docs/docs/commands/task.md Co-authored-by: Daniele Formichelli <df@bendingspoons.com> * Update Sources/TuistKit/Commands/TuistCommand.swift Co-authored-by: Daniele Formichelli <df@bendingspoons.com> * Fix finding command Co-authored-by: Daniele Formichelli <df@bendingspoons.com> * Plugins archive (#3531) Fix build issues Build and zip executable products Add tests for buildFatReleaseBinary Write tests for PluginsArchiveService Use plugin instead of plugins Add success print Format swift code Update Sources/TuistKit/Services/PluginArchiveService.swift Co-authored-by: Daniele Formichelli <df@bendingspoons.com> * Tuist plugins 2.0 fetch (#3577) * Tuist executable (#3494) * Search for executable in path with tuist prefix if not tuist command * Add acceptance test for new task * Update documentation * Check if executable exists * Update projects/docs/docs/commands/task.md Co-authored-by: Daniele Formichelli <df@bendingspoons.com> * Update Sources/TuistKit/Commands/TuistCommand.swift Co-authored-by: Daniele Formichelli <df@bendingspoons.com> * Fix finding command Co-authored-by: Daniele Formichelli <df@bendingspoons.com> * WIP: Fetch release * Install tasks to release dir * Execute plugin task * Add TuistServiceTests * Add FetchServiceTests * Remove DependenciesFetchCommand * Add fetch plugins test * Fix PluginServiceTests * Add test for new logic in PluginServiceTests * Minor changes * Revert changes to Package.resolved * Add missing throws * Rename gitID to gitReference * Move to Swift-based APIs * Fix fetch command * Uncomment analytics code * Fix acceptance tests for tuist edit * Restore Package.resolved * Fix plugins.feature acceptance test * Add fetch to tasks.feature * Add fetch to tasks.feature * Add fetch to scaffold.feature * Fix scaffold.feature * Fix tasks.feature Co-authored-by: Daniele Formichelli <df@bendingspoons.com> * Plugin commands (#3663) * Add plugin build command * Add unit tests * Add plugin acceptance tests * Update tuist_plugin submodule * Plugins 2.0: dependencies commands (#3656) * Fix fetch call when generating via fourier * Remove clean command exclusive to dependencies * WIP: tuist update * Add update flag to tuist fetch * Reuse code for fetch and update of dependencies * Fix dependencies update call in acceptance tests * Format swift code * Add fetch to tuist focus in fourier * Add TuistGraph as a dependency of TuistSupportTesting * Fix fourier tests * Restructure CleanCategory to mitigate code duplication * Format swift code * Lint code * Update fourier commands * Add missing ProjectDescription dependency * Fix CleanServiceTests * Fix PluginArchiveServiceTests * Tuist plugins 2.0 ProjectAutomation (#3816) * WIP: ProjectAutomation for new tasks * Add swiftToolsSupportDependency to ProjectAutomation * Make graph method public * Update tuist_plugin submodule * Use ENV variable instead of commandline argument for passing tusit binary path * Read file instead of stdout * Fix tests * Remove old tasks and ProjectAutomation * Fix acceptance tests * Update error documentation * Check path in TuistServiceTests * Format swift code * Tuist plugin * Fix ManifestTests * Fix test_edit_when_there_are_helpers_and_setup_and_config_and_dependencies test * Add path argument to graph * Remove plugin zip path if it exists * Format swift code * Fix tasks.feature * Remove log * Format swift code * Fix lint issues * Add docs for tuist task plugins (#3898) * Add docs for tuist task plugins * Update docs for fetching dependencies * Address code review comments Co-authored-by: Daniele Formichelli <df@bendingspoons.com> * [3.0] Merge pull request #3949 from tuist/laxmorek/bump-swift-argument-parser Update `swift-argument-parser`: `.upToNextMajor(from: "0.4.3")` -> `.upToNextMajor(from: "1.0.0")`. * [3.0] Fixed changelog. * feat: add `type` parameter to `TargetDependency.sdk` (#3961) * feat: replace SourceFileGlob init with static method (#3960) * feat: replace SourceFileGlob init with static method #393 * fix: glob static method should be added to ProjectDescription * chore: lint * fix: compilation error * fix: fixtures * fix: fix test compilation error * fix: test compilation error * chore: try to fix .build folder caching * feat: move `disableSynthesizedResourceAccessors` from `Config.swift` to `Project.ProjectOption` (#3963) * feat: move `disableSynthesizedResourceAccessors` from `Config.swift` to `Project.ProjectOption` * chore: linting * fix: fix fixture * feat: move disableBundleAccessors to ProjectOption * fix: compilation errors * chore: fix Project.swift * chore: formatting * 3️⃣ Added `sources` property to `ProjectAutomation.Target` model. (#3988) * [extend-graph-with-sources] Added `sources` property to `ProjectAutomation.Target` model. * [extend-graph-with-sources] `./fourier lint tuist --fix` * [extend-graph-with-sources] Updated docs. * 3️⃣ Drop `tuist lint` command (#4001) * 3️⃣ Merge `tuist focus` and `tuist generate` command (#3912) * Remove unused import * Fix plugins loading for Dependencies.swift * Fix lint * Fix unit test * Update step definition for `tuist fetch` * fix: fix app_with_spm_dependencies fixturre Co-authored-by: Marek Fořt <marekfort@me.com> Co-authored-by: Luis Padron <luis.padron@compass.com> Co-authored-by: Kamil Harasimowicz <kamil.harasimowicz@gmail.com> Co-authored-by: Alfredo Delli Bovi <alfredo.dellibovi@gmail.com>

feat: remove tuist focus command and replace tuist generate imple…

5587f20

…mentation with focus

danieleformichelli added this to the 3.0 milestone Dec 28, 2021

luispadron reviewed Dec 30, 2021

View reviewed changes

danieleformichelli added 7 commits December 31, 2021 16:04

Merge branch 'main' into feature/merge-generate-focus

ee84ea5

docs: improve targets documentation

411978a

chore: update fourier and docs

5c4adc2

fix: fix generate arguments

df075d5

fix: fix removing focus documentation

6657608

docs: add changelog

3601b79

docs: update documentation

4651ab0

danieleformichelli added 2 commits January 3, 2022 14:44

chore: fix fixtures using tuist focus

5e7a76d

Merge branch 'main' into feature/merge-generate-focus

6bbffdc

danieleformichelli changed the base branch from main to release/3.0 January 3, 2022 13:52

danieleformichelli requested review from luispadron and ezraberch January 3, 2022 13:52

danieleformichelli marked this pull request as ready for review January 3, 2022 13:52

danieleformichelli mentioned this pull request Jan 3, 2022

3.0 deprecations #3906

Closed

ezraberch reviewed Jan 3, 2022

View reviewed changes

projects/docs/docs/commands/generate.md Outdated Show resolved Hide resolved

Update projects/docs/docs/commands/generate.md

5cf8406

Co-authored-by: ezraberch <49635435+ezraberch@users.noreply.github.com>

ezraberch mentioned this pull request Jan 5, 2022

[Docs] Update form of internal links #3945

Merged

fortmarek reviewed Jan 8, 2022

View reviewed changes

docs: improve wording

dfae296

Co-authored-by: Marek Fořt <marekfort@me.com>

danieleformichelli requested a review from fortmarek January 9, 2022 11:05

danieleformichelli added 4 commits January 10, 2022 17:55

Merge branch 'release/3.0' into feature/merge-generate-focus

85dbb6a

fix: replace open with no-open in fourier command

b8389e0

Merge branch 'release/3.0' into feature/merge-generate-focus

4f3982a

Merge branch 'release/3.0' into feature/merge-generate-focus

15a761e

danieleformichelli added 10 commits January 11, 2022 10:46

Merge branch 'release/3.0' into feature/merge-generate-focus

71e4283

fix: fix fourier generate test

af941d8

fix: fix fourier generate --no-open

8483bcd

fix: fourier tests

6fe0c14

fix: fix adjust url

fe2ae2a

Merge branch 'release/3.0' into feature/merge-generate-focus

1887c1d

# Conflicts: # projects/docs/docs/building-at-scale/caching.md # projects/docs/docs/commands/focus.md

fix: remove building of cached out scheme

a2c758f

Merge branch 'release/3.0' into feature/merge-generate-focus

7aaa5bd

fix: fix tuist generates acceptance tests to not use cache

5242dd3

fix: fix autofocus for workspaces with project globs

24b1ece

luispadron approved these changes Jan 19, 2022

View reviewed changes

danieleformichelli added 2 commits January 19, 2022 15:57

fix: manifest loadingg error

d57adc9

fix: fix generate-3 fixture acceptance test

acb69d8

danieleformichelli changed the title ~~3️⃣ [WIP] Merge tuist focus and tuist generate command~~ 3️⃣ Merge tuist focus and tuist generate command Jan 19, 2022

danieleformichelli added 2 commits January 19, 2022 18:44

fix: fix list-targets feature

3bdb0a8

fix: fix precompiled acceptance test

0b33b7e

fortmarek approved these changes Jan 19, 2022

View reviewed changes

danieleformichelli merged commit b29e347 into release/3.0 Jan 19, 2022

danieleformichelli deleted the feature/merge-generate-focus branch January 19, 2022 21:17

danieleformichelli mentioned this pull request Jan 31, 2022

Refactor Generator and ManifestGraphLoader #4082

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

3️⃣ Merge `tuist focus` and `tuist generate` command #3912

3️⃣ Merge `tuist focus` and `tuist generate` command #3912

danieleformichelli commented Dec 28, 2021 •

edited

Loading

luispadron left a comment

adellibovi commented Jan 2, 2022

fortmarek commented Jan 8, 2022

fortmarek left a comment

3️⃣ Merge tuist focus and tuist generate command #3912

3️⃣ Merge tuist focus and tuist generate command #3912

Conversation

danieleformichelli commented Dec 28, 2021 • edited Loading

luispadron left a comment

Choose a reason for hiding this comment

adellibovi commented Jan 2, 2022

fortmarek commented Jan 8, 2022

fortmarek left a comment

Choose a reason for hiding this comment

3️⃣ Merge `tuist focus` and `tuist generate` command #3912

3️⃣ Merge `tuist focus` and `tuist generate` command #3912

danieleformichelli commented Dec 28, 2021 •

edited

Loading