Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Reference actions by commit SHA #66

Closed
wants to merge 4 commits into from
Closed

[Feature Request]: Reference actions by commit SHA #66

wants to merge 4 commits into from

Conversation

gabibguti
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build was run locally and without warnings or errors
  • All previous and new tests pass

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming, typo fix)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Referencing actions by major tag (e.g. v3)

Related Issue URL: #65

What is the new behavior?

Referencing actions by commit SHA (e.g. 8ade135a41bc03ea155e62e844d188df1ea18608)

Does this introduce a breaking change?

  • Yes
  • No

Other information

@gabibguti
Bump and ref actions by commit SHA in ci.yml
585b100 
It's important to make sure the SHA's are from the original repositories and not forks.

For reference:

https://github.com/actions/checkout/releases/tag/v4.1.0
actions/checkout@8ade135

https://github.com/actions/upload-artifact/releases/tag/v3.1.3
actions/upload-artifact@a8a3f3a
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
@gabibguti
Bump and ref actions by commit SHA in windows-ci.yml
23cadaf 
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
@gabibguti
Copy link
Contributor Author

Other information

windows-ci is failing in my fork. I tested it on the last commit it was working without changes and it failed too, maybe it needs some data only the original repository has?

@gabibguti
Copy link
Contributor Author

An idea to fix windows-ci: I can add a trigger to run on: pull_request in my fork and test if the workflow is working on this PR.

@gabibguti
(test) Add on pull request trigger to windows-ci.yml
7afa95a 
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
@gabibguti
Revert "Bump and ref actions by commit SHA in windows-ci.yml"
845e5aa 
This reverts commit 23cadaf.

Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
@gabibguti
Copy link
Contributor Author

I think the failure is not related to the PR changes, can you confirm by running the workflow on the repository?

@gabibguti
Copy link
Contributor Author

Closing this PR to make more tests locally.

@gabibguti gabibguti closed this Sep 26, 2023
@JiaT75
Copy link
Contributor

JiaT75 commented Sep 27, 2023

@gabibguti It looks like Windows CI is broken on the master branch, so thanks for letting us know. I have it set it up to only run manually because it runs much slower than Ubuntu and Mac OS runners. I suppose I should manually run it more often.

We have been doing a few Windows related changes for xz recently so thats likely what broke it. I will investigate the issue and let you know when it is fixed.

@gabibguti
Copy link
Contributor Author

Ok, thanks for the confirmation, Jia!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabibguti @JiaT75