Discard messages with a lower offset than requested #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nevon
reviewed
Jul 31, 2018
| @@ -3,9 +3,27 @@ const Batch = require('../batch') | |||
| describe('Consumer > Batch', () => { | |||
| const topic = 'topic-name' | |||
|
|
|||
| it('discards messages with a lower offset than the requested', () => { | |||
| const fetchedOffset = 3 | |||
There was a problem hiding this comment.
Not that it matters for these cases, but shouldn't fetchedOffset always be a string?
There was a problem hiding this comment.
Everything will be converted into a long so, technically yes, but in the end it doesn't matter that much. Numbers highlight better in the test
Nevon
approved these changes
Jul 31, 2018
tulios
deleted the
discard-messages-with-a-lower-offset-than-requested
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetch can return message sets with a lower offset than the requested, for example, we fetch data from offset 77 but receive a message set starting with offset 51. This behavior happens due to how Kafka stores the message sets on disk. When seeking to different offsets than the natural flow (from the beginning or the end), it can lead to "wrong" batches.