Change typing of logLevel argument to logCreator #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nevon
reviewed
Oct 31, 2019
types/index.d.ts
Outdated
| @@ -364,7 +364,7 @@ export interface LoggerEntryContent { | |||
|
|
|||
| export type Logger = (entry: LogEntry) => void | |||
|
|
|||
| export type logCreator = (logLevel: string) => (entry: LogEntry) => void | |||
| export type logCreator = (logLevel: number) => (entry: LogEntry) => void | |||
There was a problem hiding this comment.
Shouldn't this be using the logLevel enum instead of number?
There was a problem hiding this comment.
You are absolutely right!
|
Thanks for the contribution! Just a question about whether or not we can restrict the type to the appropriate enum. |
|
This is available in the pre-release version 1.12.0-beta.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kafkajs log levels are numeric at runtime, but the typescript declarations for the logCreator function takes a string argument. This PR changes the argument's type and adds a test for it.