Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deleteGroups admin API implementation #646

Merged
merged 18 commits into from
Mar 23, 2020
Merged

deleteGroups admin API implementation #646

merged 18 commits into from
Mar 23, 2020

Conversation

dfilkovi
Copy link
Contributor

Added deleteGroups API implementation

@dfilkovi dfilkovi requested a review from Nevon February 24, 2020 19:28
src/admin/__tests__/deleteGroups.spec.js Outdated Show resolved Hide resolved
src/admin/index.js Outdated Show resolved Hide resolved
src/admin/index.js Outdated Show resolved Hide resolved
src/protocol/requests/deleteGroups/index.js Show resolved Hide resolved
src/admin/__tests__/deleteGroups.spec.js Show resolved Hide resolved
src/admin/__tests__/deleteGroups.spec.js Show resolved Hide resolved
src/admin/index.js Outdated Show resolved Hide resolved
src/admin/index.js Show resolved Hide resolved
src/admin/index.js Show resolved Hide resolved
src/admin/index.js Outdated Show resolved Hide resolved
src/protocol/requests/deleteGroups/index.js Show resolved Hide resolved
src/admin/index.js Outdated Show resolved Hide resolved
@dfilkovi
Copy link
Contributor Author

@Nevon what changes are need? Can't seem to find out change request here...

@Nevon
Copy link
Collaborator

Nevon commented Mar 23, 2020

There were no more changes required. I just hadn't re-reviewed the PR since last time. Looks good to me now!

@Nevon Nevon merged commit 3601d7a into tulios:master Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants