Fix the return value of Cluster.findTopicPartitionMetadata #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nevon
approved these changes
Jun 30, 2020
Nevon
reviewed
Jun 30, 2020
| @@ -30,7 +30,7 @@ module.exports = ({ logger, cluster, partitioner, eosManager }) => { | |||
| for (const { topic, messages } of topicMessages) { | |||
| const partitionMetadata = cluster.findTopicPartitionMetadata(topic) | |||
|
|
|||
| if (keys(partitionMetadata).length === 0) { | |||
There was a problem hiding this comment.
The fact that this works is kind of a funny Javascript-ism. 🙈
|
Thanks. If you fix the conflict I'll merge this. |
ankon
force-pushed
the
pr/find-topic-partition-metadata-type
branch
from
7da0fa9
to
901dd7f
Compare
|
Turns out I didn't split another PR properly, and the actual change in the type was already merged with 78fefe2, so this PR is only updating the users to match as well. (Rebased onto current master) |
|
And now this needs a merge as well. |
The return value is not an Object, but an Array (of PartitionMetadata objects). This means we can simply check the number of entries and don't need to calculate the keys when sending messages. Similarly tests need to use the correct arrays rather than some unrelated values.
ankon
force-pushed
the
pr/find-topic-partition-metadata-type
branch
from
901dd7f
to
df1d820
Compare
|
There you go :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The return value is not an Object, but an Array (of PartitionMetadata objects). This also means we can
simply check the number of entries and don't need to calculate the keys when sending messages.
Note that this exposed a bunch of problems in the tests as well: the mocked calls not just returned the
wrong type, but in fact returned a completely unrelated value.