Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Fetch v9 protocol (minimal) #778

Merged
merged 3 commits into from
Jul 20, 2020
Merged

Support Fetch v9 protocol (minimal) #778

merged 3 commits into from
Jul 20, 2020

Conversation

ankon
Copy link
Contributor

@ankon ankon commented Jun 23, 2020

NOTE: This is a draft on top of the earlier #776, and merely here as a "intent to get this merged". Fetch v9 is needed as precondition for #713.

@ankon ankon marked this pull request as draft June 23, 2020 19:21
@ankon ankon mentioned this pull request Jun 24, 2020
@ankon ankon force-pushed the pr/fetch-v9 branch 2 times, most recently from 87fba83 to 644572c Compare June 25, 2020 20:50
@ankon
Copy link
Contributor Author

ankon commented Jun 25, 2020

Test failures are unrelated, see #786

This commit only adds the minimal "support" for the Fetch API v9 on the protocol level, but
does not implement the additional logic described by KIP-320 to better handle unclear leader
elections.

In particular KIP-320 allows a client to "opt-out" of the complex leader epoch validation,
and at that point only changes the Fetch API to use two different error codes as replacement
for the previous code indicating "metadata is stale".
@ankon ankon marked this pull request as ready for review June 27, 2020 10:17
@Nevon
Copy link
Collaborator

Nevon commented Jul 20, 2020

Created #818 to document what functionality Fetch V9 introduces that we don't currently support.

@Nevon Nevon merged commit 46d5f54 into tulios:master Jul 20, 2020
@ankon ankon deleted the pr/fetch-v9 branch September 14, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants