Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve socket requests without response immediately when they have been queued #785

Merged

Conversation

ankon
Copy link
Contributor

@ankon ankon commented Jun 24, 2020

Found while working on #776 and reading the code in the request queue: When we push a request that doesn't need a reply and we can execute it immediately we will do so, and then properly complete the request. But: When the request would have to be enqueued we will not check the "does it need a response", and so likely this request will just get stuck somehow.

@goriunov
Copy link
Contributor

Nice catch ! :)

@Nevon
Copy link
Collaborator

Nevon commented Jun 25, 2020

I could have sworn I already commented on this yesterday, but yeah, nice catch. I am however perplexed as to how this ever worked, then. Maybe it's just rare that you make a request where you don't expect a response while you are also hitting the maxInFlightRequests limit, so no one noticed.

@Nevon Nevon merged commit d86af3a into tulios:master Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants