Resolve socket requests without response immediately when they have been queued #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch ! :) |
|
I could have sworn I already commented on this yesterday, but yeah, nice catch. I am however perplexed as to how this ever worked, then. Maybe it's just rare that you make a request where you don't expect a response while you are also hitting the maxInFlightRequests limit, so no one noticed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while working on #776 and reading the code in the request queue: When we push a request that doesn't need a reply and we can execute it immediately we will do so, and then properly complete the request. But: When the request would have to be enqueued we will not check the "does it need a response", and so likely this request will just get stuck somehow.