Add new protocol errors #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
None of these new errors have any impact that would currently require code changes, as they are all in relation to functionality that KafkaJS doesn't currently have. The one exception being INVALID_RECORD, which we currently could get when producing, in which case we would just log that it's an unknown protocol error. When Produce v8 is implemented, this error could be improved by including more information about the invalid record.
goriunov
approved these changes
Aug 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None of these new errors have any impact that would currently require code changes, as they are all in relation to functionality that KafkaJS doesn't currently have.
The one exception being INVALID_RECORD, which we currently could get when producing, in which case we would just log that it's an unknown protocol error. When Produce v8 is implemented, this error could be improved by including more information about the invalid record. https://cwiki.apache.org/confluence/display/KAFKA/KIP-467%3A+Augment+ProduceResponse+error+messaging+for+specific+culprit+records