-
-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding versioning to docs. #835
Conversation
Thanks for taking a stab at this. This is something that's been highly requested, and will reduce the number of incoming questions by quite a bit. First, let's see if I understand Docusaurus versioning correctly.
If this is correct, then that seems good to me. One concern that I had was breaking existing links, but that shouldn't be the case since the current version will always be available at One thing that we'll need to address, probably, is how we generate URLs to the docs, since ideally we'd want to point to the docs for that version of KafkaJS, so we'll need to read that from the package.json. This does not need to be addressed within the scope of this PR, however. kafkajs/src/utils/websiteUrl.js Line 3 in 7d7a765
Yes, I believe we should create a version whenever we create a new (stable) release, basically. It seems a lot simpler than trying to conditionally create versions only for minor and major releases. I don't think we should create versions for the beta releases. If you're using the beta version of the package, you can just rely on However, I don't think you need to go back and create versions for all of those now. I'm perfectly fine with just having
That would be nice. I would say it's another job with similar conditions to the release job: https://github.com/tulios/kafkajs/blob/master/azure-pipelines.yml#L211-L235 The steps would be similar to the website build, except that instead of invoking the Docusaurus "publish-to-gh-pages" action we would invoke the One thing you could do, however, would be to revert this commit, since it will no longer be necessary. |
Hey @Nevon,
Correct.
Correct. And you can view all the versions by visiting /versions
Not really, the latest version will always be at
Correct.
I thought as much :) I'll revert that commit now as well. |
Let me know if there's anything else you want to address before we merge this. |
I think that's all from me 😄 |
Then let's give it a whirl and see what happens. |
This PR takes a first run at #279.
I currently only have the following versions:
I have a question around the tags, should i also be doing the minor updates docs as well e.g 1.9.0, 1.9.1, 1.9.2?
Not sure if we will need to look at adding in a job to
azure-pipelines.yml
to allow adding a versioned document based on a tag e.g:cd website && yarn run version ${TAG}