Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better integration of third party libraries #101

Open
2 of 4 tasks
JoGei opened this issue Dec 7, 2021 · 7 comments
Open
2 of 4 tasks

Better integration of third party libraries #101

JoGei opened this issue Dec 7, 2021 · 7 comments

Comments

@JoGei
Copy link
Member

JoGei commented Dec 7, 2021

Third party integration in ETISS is a bit intransparent. A lot of libraries are copy-pasted into ETISS source code which is mostly fine, but makes is harder to maintain and differ what foreign code is used (e.g., versioning, missing copyrights/licenses). A few examples, I am aware of:

  • pugixml - used in fault injection
  • legacy softfloat - kind of anyway a duplicate for the src/jitlib/softfloat
  • simpleini - extensive use in ETISS runtime configuration
  • tcc - fetched via CMake execute_process

A possible solution to this could be to add a third_party/ directory to ETISS' root to integrate such things - either through git submodules or CMake's FetchContent. Please feel free to extend the list above, if you are aware of more.

@wysiwyng
Copy link
Contributor

wysiwyng commented Dec 7, 2021

I would possibly add tcc to this list, currently it is downloaded and built using CMake's execute_process interfaces, which is arguably not "the best way to do it"™. I have no idea how this could be made nicer, though.

@JoGei
Copy link
Member Author

JoGei commented Dec 16, 2022

simpleini fixed with f53752f

@JoGei
Copy link
Member Author

JoGei commented Dec 16, 2022

tcc fixed with #125

@wysiwyng
Copy link
Contributor

As far as I see it, the mentioned softfloat is only used for the OR1K core, which probably can be deprecated anyways.

@JoGei
Copy link
Member Author

JoGei commented Dec 16, 2022

Agree, but then we should remove OR1K Arch, too.

@JoGei
Copy link
Member Author

JoGei commented Dec 16, 2022

pugixml: would be fixed with merge of #132

@JoGei
Copy link
Member Author

JoGei commented Feb 23, 2023

Opened a Draft PR: #132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants