Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update api docs to add option for deleting a single IP #508

Merged
merged 1 commit into from
Mar 8, 2017

Conversation

ssgelm
Copy link
Contributor

@ssgelm ssgelm commented Jan 29, 2017

As added in #505. This updates the docs to go along with that PR.

@ssgelm ssgelm mentioned this pull request Jan 29, 2017
@defect
Copy link
Contributor

defect commented Jan 29, 2017

Awesome, thanks! 👍

_data/api.yml Outdated
@@ -1758,6 +1758,9 @@ sections:
pool:
type: Option[String]
description: If specified, only addresses associated with the given pool are deleted. Otherwise, all addresses are deleted.
address:
type: Option[String]
description: If specified, delete only the given address.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps something like:
If specified, delete only the given address, else all of them.

and modify:
description: Delete all addresses associated with a given tag, optionally associated with a pool
to be something like:
description: Delete addresses associated with a given tag, optionally associated with a pool, or optional single address

@ssgelm ssgelm force-pushed the docs-update-delete-single-ip branch from 9b577b5 to 8a7fbe4 Compare February 6, 2017 05:37
@ssgelm
Copy link
Contributor Author

ssgelm commented Feb 6, 2017

@roymarantz I updated the docs as requested. Does this look better?

@@ -1748,7 +1748,7 @@ sections:
}
}
"delete an address":
description: Delete all addresses associated with a given tag, optionally associated with a pool
description: Delete addresses associated with a given tag: either all addresses, those associated with a specified pool, or a single address.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code seem to support specifying a pool and address. is it wrong or is this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code should support it but I'm not sure what the value would be.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I was just misreading this, so don't worry about it.

@roymarantz
Copy link
Contributor

👍

@byxorna byxorna merged commit 86135ee into tumblr:gh-pages Mar 8, 2017
@byxorna byxorna mentioned this pull request Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants