Improve ergonomics for non-expert users #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seemed out-of-place in the main routine, which is complex as it is.
- Print "Please use --base to specify the base commit." when all the commits were "hidden" by other branches. (This makes the misbehavior described in tummychow#9 less confusing.) - Instead of noting that "merge commit found", explain what it means to the user: "Will not fix up past the merge commit". - Provide suggestions when "stack limit reached": "use --base or configure absorb.maxStack to override" - Don't honor absorb.maxStack with explicit --base - Note if the stack is empty: "No commits available to fix up, exiting" - Warn if "No additions staged, try adding something to the index." - Print "Could not find a commit to fix up, use --base to increase the search range." instead of "could not find noncommutative commit", and display this message by default (without the verbose mode)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't stop quietly when we do nothing, instead print a message with suggestions on what the user can do.