Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

Gestures' action icon position #18

Open
mvietri opened this issue Jan 15, 2019 · 5 comments · May be fixed by #121
Open

Gestures' action icon position #18

mvietri opened this issue Jan 15, 2019 · 5 comments · May be fixed by #121
Labels
design Changes to the design of the app

Comments

@mvietri
Copy link

mvietri commented Jan 15, 2019

When you scroll down a comment that is larger than the screen viewport swipe gesture don't show the icon since it is in a fixed position (center/vertical), so you get the actions color but no the actions icon.

I'm working on this 'solution', to keep the icon on the top of the comment area instead of the middle:

gestures

Thoughts?

@dotvhs
Copy link

dotvhs commented Jan 15, 2019

Looks very nice, would it be hard though to make it in the middle of visible space? Just curious.

@mvietri
Copy link
Author

mvietri commented Jan 15, 2019

I'll try that on the weekend!

@Tunous Tunous added the design Changes to the design of the app label Jan 20, 2019
@mvietri mvietri changed the title Gestures' action icon are out of view when the comment is longer than screen Gestures' action icon position Jan 20, 2019
@mvietri
Copy link
Author

mvietri commented Aug 18, 2019

A little update. I really like this approach where icons are at the same level of the touch event.

swipe

@Tunous
Copy link
Owner

Tunous commented Oct 30, 2019

@Esselans Hey, can you send this in a form of pull request or is there anything which blocked further development of this feature?

@mvietri
Copy link
Author

mvietri commented Nov 11, 2019

@Tunous Sure. I'll make a draft pr as soon as I can.

@mvietri mvietri linked a pull request Nov 12, 2019 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design Changes to the design of the app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants