-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An example in Typescript #50
Comments
Hey, thanks alot. I don't know much about TypeScript so I didn't do the Typings. How are you going with the remaining points? |
Sadly I'm also not a Typescript expert (at least not yet;). So for now the next steps for me are:
|
Closing issue due to lack of response/interest in TypeScript. |
Hi, I know this is closed, however, we need some basic typings to carry on using polymer-redux in our project. I can go about this 2 ways, I can create a separate NPM module that people can use to install the types separately or we can ship an index.d.ts file alongside the index.js (with a reference) the file isn't going to be very big (less than 20 lines) which just gives the very basic of types for this, others can add to it later should they wish. Typescript works by searching all files including the node_modules folder for .ts or d.ts files, so there is no extra config required, simply just this file. My question is which way would you prefer, I'm happy to create a PR to add this single file, a separate NPM module, will require more managing. |
Please, add the |
+1 trying to slowly rewrite my polymer 1.9/redux app into poly3 with typescript. I've just started and i think i'm going to try using your example. Let's see where i'll get |
i've managed to make everything in order to work, except for the polymer-redux .d.ts file. Can anyone help about this? |
As long as you have an index.d.ts in the root, in the using project Typescript will find all of these. The trouble that I forsee is that the specific typings of polymer that we also want is only available in polymer itself and not there typings that they released. |
I had some problems using polymer-redux with Typescript. So I created an example that helped me fixing them:
https://github.com/pme123/polymer-redux-typescript-example
It is based on a Javascript version:
https://github.com/jdomzhang/polymer-redux-example
It works - but I have 2 remaining open points:
Nothing blocking but I hope to solve them some time.
The text was updated successfully, but these errors were encountered: