Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XYZ_sigma of EmitterSet does not convert as xyz does #2

Closed
Haydnspass opened this issue Sep 30, 2020 · 1 comment
Closed

XYZ_sigma of EmitterSet does not convert as xyz does #2

Haydnspass opened this issue Sep 30, 2020 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@Haydnspass
Copy link
Collaborator

EmitterSet features automatic conversion of px and nm for xyz which are derived properties of an internal xyz container. They can also be set via a setter method as

em = EmitterSet(xy_unit='px')
em.xyz_nm = ...
--> em.xy_unit : 'nm'

however the sigma values remain in the original unit. I don't really know how to best handle this, or just issue a warning.

@Haydnspass Haydnspass added bug Something isn't working enhancement New feature or request labels Sep 30, 2020
@Haydnspass
Copy link
Collaborator Author

Do not try to save the user from doing it wrong. Keep as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant