Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step with ignore error = true and output calculation failure #419

Closed
vhadianto opened this issue Dec 6, 2023 · 2 comments
Closed

Step with ignore error = true and output calculation failure #419

vhadianto opened this issue Dec 6, 2023 · 2 comments
Assignees
Labels

Comments

@vhadianto
Copy link
Contributor

Current thought is to not fail the step but add the output calculation failure to the step error.

@vhadianto
Copy link
Contributor Author

vhadianto commented Dec 6, 2023

We have a list of questions at this point.

When error ignore true is on, how do we handle these cases:

  • step output render error
  • throw if condition render error
  • throw
  • loop render error
  • retry render error

Same question probably applies for when retry { } should be used ... does it apply to the things above?

Tagging @johnsmyth, @cbruno10 & @e-gineer

@vhadianto vhadianto self-assigned this Dec 7, 2023
@e-gineer
Copy link
Contributor

e-gineer commented Dec 7, 2023

There are three types of errors in a pipeline run:

  • evaluation error, e.g. unknown attribute on referenced var
  • unexpected error during a step, e.g. image not found
  • runtime error, e.g. non-zero exit code

Evaluation errors always fail the step immediately and completely. The retry and error block settings are ignored.

Unexpected and runtime errors are handled by the user and their pipeline definition. They respect retry and error block settings for the step.

In the future we could add a new property to the error and retry blocks to optionally handle evaluation errors.

vhadianto added a commit that referenced this issue Dec 9, 2023
…or handling to ensure that it matches specification in issue #419. (#479)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants