Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to query App Service > Web App & Function App table FTP & HTTP settings. Closes #52 #77

Merged
merged 3 commits into from
Apr 8, 2021

Conversation

Subhajit97
Copy link
Contributor

@Subhajit97 Subhajit97 commented Apr 2, 2021

Integration test logs

Logs
N/A

Example query results

Results
select
  name,
  enabled,
  region
from
  azure_app_service_web_app
where
  (configuration -> 'properties' ->> 'http20Enabled')::boolean;
+-----------------------+---------+---------+
| name                  | enabled | region  |
+-----------------------+---------+---------+
| testappconfig02042021 | true    | east us |
+-----------------------+---------+---------
select
  name,
  configuration -> 'properties' ->> 'ftpsState' as ftps_state
from
  azure_app_service_web_app
where
  configuration -> 'properties' ->> 'ftpsState' <> 'AllAllowed';
+-----------------------+------------+
| name                  | ftps_state |
+-----------------------+------------+
| testappconfig02042021 | Disabled   |
+-----------------------+------------+

Copy link
Contributor

@LalitLab LalitLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine.
Can you try to add an example for Hydrate Functions added to table

@LalitLab
Copy link
Contributor

LalitLab commented Apr 7, 2021

Also, can add below to examples

9.9 Ensure that 'HTTP Version' is the latest, if used to run the web app (Manual)

select
  name,
  enabled,
  region
from
  azure_app_service_web_app
where
  (configuration -> 'properties' ->> 'http20Enabled')::boolean;

9.10 Ensure FTP deployments are disabled (Automated)

select
  name,
  configuration -> 'properties' ->> 'ftpsState' as ftps_state
from
  azure_app_service_web_app
where
  configuration -> 'properties' ->> 'ftpsState' <> 'AllAllowed';

@Subhajit97 Subhajit97 requested a review from LalitLab April 8, 2021 12:17
@LalitLab LalitLab merged commit 7b5f1f8 into main Apr 8, 2021
@LalitLab LalitLab deleted the issue-52 branch April 8, 2021 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to query App Service > Web App & Function App table FTP & HTTP settings
2 participants