Add support for VHD (Virtual Hard Disks) encryption check. closes #50 #88

sayan133 · 2021-04-09T10:26:28Z

Integration test logs

Logs

No env file present for the current environment:  staging 
 Falling back to .env config
No env file present for the current environment:  staging
customEnv TURBOT_TEST_EXPECTED_TIMEOUT undefined

SETUP: tests/azure_compute_virtual_machine []

PRETEST: tests/azure_compute_virtual_machine

TEST: tests/azure_compute_virtual_machine
Running terraform
azurerm_resource_group.named_test_resource: Creating...
azurerm_resource_group.named_test_resource: Creation complete after 2s [id=/subscriptions/cd4401c4-3cc8-4565-a594-839c1e345f1e/resourceGroups/turbottest69292]
azurerm_virtual_network.named_test_resource: Creating...
azurerm_virtual_network.named_test_resource: Creation complete after 9s [id=/subscriptions/cd4401c4-3cc8-4565-a594-839c1e345f1e/resourceGroups/turbottest69292/providers/Microsoft.Network/virtualNetworks/turbottest69292]
azurerm_subnet.named_test_resource: Creating...
azurerm_subnet.named_test_resource: Creation complete after 2s [id=/subscriptions/cd4401c4-3cc8-4565-a594-839c1e345f1e/resourceGroups/turbottest69292/providers/Microsoft.Network/virtualNetworks/turbottest69292/subnets/turbottest69292]
azurerm_network_interface.named_test_resource: Creating...
azurerm_network_interface.named_test_resource: Creation complete after 6s [id=/subscriptions/cd4401c4-3cc8-4565-a594-839c1e345f1e/resourceGroups/turbottest69292/providers/Microsoft.Network/networkInterfaces/turbottest69292]
azurerm_virtual_machine.named_test_resource: Creating...
azurerm_virtual_machine.named_test_resource: Still creating... [10s elapsed]
azurerm_virtual_machine.named_test_resource: Still creating... [20s elapsed]
azurerm_virtual_machine.named_test_resource: Still creating... [30s elapsed]
azurerm_virtual_machine.named_test_resource: Still creating... [40s elapsed]
azurerm_virtual_machine.named_test_resource: Creation complete after 47s [id=/subscriptions/cd4401c4-3cc8-4565-a594-839c1e345f1e/resourceGroups/turbottest69292/providers/Microsoft.Compute/virtualMachines/turbottest69292]

Warning: Deprecated Resource

The null_data_source was historically used to construct intermediate values to
re-use elsewhere in configuration, the same can now be achieved using locals


Warning: Version constraints inside provider configuration blocks are deprecated

  on variables.tf line 22, in provider "azurerm":
  22:   version         = "=1.36.0"

Terraform 0.13 and earlier allowed provider version constraints inside the
provider configuration block, but that is now deprecated and will be removed
in a future version of Terraform. To silence this warning, move the provider
version constraint into the required_providers block.


Warning: Interpolation-only expressions are deprecated

  on variables.tf line 117, in output "resource_name_upper":
 117:   value = "${upper(var.resource_name)}"

Terraform 0.11 and earlier required all non-constant expressions to be
provided via interpolation syntax, but this pattern is now deprecated. To
silence this warning, remove the "${ sequence from the start and the }"
sequence from the end of this expression, leaving just the inner expression.

Template interpolation syntax is still used to construct strings from
expressions when the template includes multiple interpolation sequences or a
mixture of literal strings and interpolations. This deprecation applies only
to templates that consist entirely of a single interpolation sequence.


Apply complete! Resources: 5 added, 0 changed, 0 destroyed.

Outputs:

resource_aka = "azure:///subscriptions/cd4401c4-3cc8-4565-a594-839c1e345f1e/resourceGroups/turbottest69292/providers/Microsoft.Compute/virtualMachines/turbottest69292"
resource_aka_lower = "azure:///subscriptions/cd4401c4-3cc8-4565-a594-839c1e345f1e/resourcegroups/turbottest69292/providers/microsoft.compute/virtualmachines/turbottest69292"
resource_id = "/subscriptions/cd4401c4-3cc8-4565-a594-839c1e345f1e/resourceGroups/turbottest69292/providers/Microsoft.Compute/virtualMachines/turbottest69292"
resource_name = "turbottest69292"
resource_name_upper = "TURBOTTEST69292"
subscription_id = "cd4401c4-3cc8-4565-a594-839c1e345f1e"

Running SQL query: test-get-query.sql
[
  {
    "admin_user_name": "testadmin",
    "computer_name": "hostname",
    "disable_password_authentication": false,
    "id": "/subscriptions/cd4401c4-3cc8-4565-a594-839c1e345f1e/resourceGroups/turbottest69292/providers/Microsoft.Compute/virtualMachines/turbottest69292",
    "image_offer": "UbuntuServer",
    "image_publisher": "Canonical",
    "image_sku": "16.04-LTS",
    "image_version": "latest",
    "name": "turbottest69292",
    "os_disk_caching": "ReadWrite",
    "os_disk_create_option": "FromImage",
    "os_disk_name": "turbottest69292",
    "os_type": "Linux",
    "priority": "",
    "provision_vm_agent": true,
    "region": "eastus",
    "require_guest_provision_signal": true,
    "resource_group": "turbottest69292",
    "size": "Standard_DS1_v2",
    "subscription_id": "cd4401c4-3cc8-4565-a594-839c1e345f1e",
    "type": "Microsoft.Compute/virtualMachines"
  }
]
✔ PASSED

Running SQL query: test-hydrate-query.sql
[
  {
    "admin_user_name": "testadmin",
    "computer_name": "hostname",
    "disable_password_authentication": false,
    "id": "/subscriptions/cd4401c4-3cc8-4565-a594-839c1e345f1e/resourceGroups/turbottest69292/providers/Microsoft.Compute/virtualMachines/turbottest69292",
    "image_offer": "UbuntuServer",
    "image_publisher": "Canonical",
    "image_sku": "16.04-LTS",
    "image_version": "latest",
    "name": "turbottest69292",
    "os_disk_caching": "ReadWrite",
    "os_disk_create_option": "FromImage",
    "os_disk_name": "turbottest69292",
    "os_type": "Linux",
    "priority": "",
    "provision_vm_agent": true,
    "region": "eastus",
    "require_guest_provision_signal": true,
    "resource_group": "turbottest69292",
    "size": "Standard_DS1_v2",
    "subscription_id": "cd4401c4-3cc8-4565-a594-839c1e345f1e",
    "type": "Microsoft.Compute/virtualMachines"
  }
]
✔ PASSED

Running SQL query: test-list-query.sql
[
  {
    "id": "/subscriptions/cd4401c4-3cc8-4565-a594-839c1e345f1e/resourceGroups/TURBOTTEST69292/providers/Microsoft.Compute/virtualMachines/turbottest69292",
    "name": "turbottest69292",
    "type": "Microsoft.Compute/virtualMachines"
  }
]
✔ PASSED

Running SQL query: test-not-found-query.sql
null
✔ PASSED

Running SQL query: test-turbot-query.sql
[
  {
    "akas": [
      "azure:///subscriptions/cd4401c4-3cc8-4565-a594-839c1e345f1e/resourceGroups/turbottest69292/providers/Microsoft.Compute/virtualMachines/turbottest69292",
      "azure:///subscriptions/cd4401c4-3cc8-4565-a594-839c1e345f1e/resourcegroups/turbottest69292/providers/microsoft.compute/virtualmachines/turbottest69292"
    ],
    "name": "turbottest69292",
    "tags": {
      "name": "turbottest69292"
    },
    "title": "turbottest69292"
  }
]
✔ PASSED

POSTTEST: tests/azure_compute_virtual_machine

TEARDOWN: tests/azure_compute_virtual_machine

SUMMARY:

1/1 passed.

Example query results

Results

Virtual machine VHD info

select
  name,
  power_state,
  vm_id,
  os_type,
  os_disk_vhd_uri
from
  azure_compute_virtual_machine;

+----------------+-------------+--------------------------------------+---------+-----------------------------------------------------------------------------------+
| name           | power_state | vm_id                                | os_type | os_disk_vhd_uri                                                                           |
+----------------+-------------+--------------------------------------+---------+-----------------------------------------------------------------------------------+
| test-steampipe | running     | b7c39910-84b0-4548-a143-5999dd36a913 | Linux   | https://turbotrgdisks.blob.core.windows.net/vhds/test-steampipe20210409155939.vhd |
+----------------+-------------+--------------------------------------+---------+-----------------------------------------------------------------------------------+

We can fetch the storage account name from the VHD URI & from that storage account name, we can check the encryption status for the storage account containing the VHD blob

rajlearner17

LGTM

cbruno10

Please see comment, thanks!

cbruno10 · 2021-04-14T19:03:53Z

azure/table_azure_compute_virtual_machine.go

@@ -237,6 +237,12 @@ func tableAzureComputeVirtualMachine(_ context.Context) *plugin.Table {
 				Type:        proto.ColumnType_BOOL,
 				Transform:   transform.FromField("VirtualMachineProperties.AdditionalCapabilities.UltraSSDEnabled"),
 			},
+			{
+				Name:        "vhd_uri",


@sayan133 @LalitTurbot What is our strategy here on determining the column name? It seems like VirtualMachineProperties has different properties with different depths. In this case, for vhd_uri, Terraform has a field for it, but others like require_guest_provision_signal don't. Another example is for linux_configuration_ssh_public_keys, we include linux_configuration_ssh, but for provision_vm_agent we don't.

For provision_vm_agent we should have prefix linux_configuration_ssh
In Azure properties are deeply nested - in the case of properties inside the OsProfile key -- the description of the column explains generally attribute clearly(for this reason avoided os_profile - prefix)

cbruno10

Please see suggested column name change

cbruno10 · 2021-05-04T18:53:33Z

azure/table_azure_compute_virtual_machine.go

@@ -237,6 +237,12 @@ func tableAzureComputeVirtualMachine(_ context.Context) *plugin.Table {
 				Type:        proto.ColumnType_BOOL,
 				Transform:   transform.FromField("VirtualMachineProperties.AdditionalCapabilities.UltraSSDEnabled"),
 			},
+			{
+				Name:        "vhd_uri",


Suggested change

Name: "vhd_uri",

Name: "os_disk_vhd_uri",

Add support for VHD (Virtual Hard Disks) encryption check. closes #50

8a6b0fb

sayan133 requested a review from Paulami30 April 9, 2021 10:26

sayan133 self-assigned this Apr 9, 2021

Paulami30 approved these changes Apr 13, 2021

View reviewed changes

rajlearner17 approved these changes Apr 13, 2021

View reviewed changes

cbruno10 requested changes Apr 14, 2021

View reviewed changes

Subhajit97 linked an issue May 4, 2021 that may be closed by this pull request

Add support for VHD (Virtual Hard Disks) encryption check. #50

Closed

cbruno10 requested changes May 4, 2021

View reviewed changes

Renamed vhd_uri column to os_disk_vhd_uri

75d2f6b

cbruno10 approved these changes May 5, 2021

View reviewed changes

cbruno10 merged commit 78fb21a into main May 5, 2021

cbruno10 deleted the issue-50 branch May 5, 2021 12:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for VHD (Virtual Hard Disks) encryption check. closes #50 #88

Add support for VHD (Virtual Hard Disks) encryption check. closes #50 #88

sayan133 commented Apr 9, 2021 •

edited

Loading

rajlearner17 left a comment

cbruno10 left a comment

cbruno10 Apr 14, 2021

LalitLab Apr 15, 2021

cbruno10 left a comment

cbruno10 May 4, 2021

Add support for VHD (Virtual Hard Disks) encryption check. closes #50 #88

Add support for VHD (Virtual Hard Disks) encryption check. closes #50 #88

Conversation

sayan133 commented Apr 9, 2021 • edited Loading

Integration test logs

Example query results

Virtual machine VHD info

rajlearner17 left a comment

Choose a reason for hiding this comment

cbruno10 left a comment

Choose a reason for hiding this comment

cbruno10 Apr 14, 2021

Choose a reason for hiding this comment

LalitLab Apr 15, 2021

Choose a reason for hiding this comment

cbruno10 left a comment

Choose a reason for hiding this comment

cbruno10 May 4, 2021

Choose a reason for hiding this comment

sayan133 commented Apr 9, 2021 •

edited

Loading