-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vector diskann impl #1560
Merged
Merged
Vector diskann impl #1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sivukhin
force-pushed
the
vector-diskann-impl
branch
from
July 17, 2024 12:55
12a206c
to
1e92d96
Compare
haaawk
reviewed
Jul 17, 2024
haaawk
reviewed
Jul 17, 2024
haaawk
reviewed
Jul 17, 2024
haaawk
reviewed
Jul 17, 2024
haaawk
reviewed
Jul 17, 2024
haaawk
approved these changes
Jul 17, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jul 18, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Third branch in the series for DiskANN implementation. This PR introduce DiskANN algorithm itself 🎉
The algorithm core based on the paper LM-DiskANN: Low Memory Footprint in
Disk-Native Dynamic Graph-Based ANN Indexing
Current implementation can be suboptimal in some places due to usage of very trivial data structures (lists / arrays). That's how it was intended - we will improve performance in the subsequent PRs but make this one simpler.
Nevertheless, this PR tries to address most heavy operation in the algorithm - reading blobs from disk - and aims to make as little reads as possible (utilizing
sqlite3_blob_reopen
if possible).From the performance perspective rough hierarchy of operation cost looks like this:
Changes
BlobSpot
code for cases when previous call to open/reopen failed (and blob became useless as all subsequent operations will returnSQLITE_ABORT
error; readsqlite3_blob_*
docstrings for more details)test_libsql_diskann.c
(it's a bit hacky for now - but it's fine since we soon will get merge full integration with SQLite and will no longer need these tests anymore, actually)